Skip to content

Add hover effects to navigation components for better user interaction feedback#69151

Merged
MonilBhavsar merged 14 commits into
Expensify:mainfrom
cosmicvulpes:feat/hover-effects-navigation
Sep 9, 2025
Merged

Add hover effects to navigation components for better user interaction feedback#69151
MonilBhavsar merged 14 commits into
Expensify:mainfrom
cosmicvulpes:feat/hover-effects-navigation

Conversation

@cosmicvulpes

@cosmicvulpes cosmicvulpes commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

Explanation of Change

This PR adds hover effects to navigation components to provide better visual feedback when users interact with them. The changes include:

  • Navigation Tab Bar Items: Added hover state styling that changes the background color to sidebarHover when hovered
  • Floating Action Button: Added hover effect that applies successHover background color when hovered (only when not active)
  • Navigation Tab Bar Avatar: Added hover effect that shows a green ring around the avatar when hovered
  • Enhanced Testability: Added testID attributes to key components for better testing
  • Comprehensive Testing: Added unit tests to verify hover functionality works correctly

The hover effects improve the user experience by providing immediate visual feedback, making the interface feel more responsive and interactive.

Fixed Issues

$ #67369
PROPOSAL: #67369 (comment)

Tests

  1. Navigate to the main app interface/ home page after login
  2. Hover over navigation tab bar items (Inbox, Reports, Workspaces)
  3. Verify Icon color changes to sucess hover color and the background color changes to indicate hover state
  4. Hover over the floating action button
  5. Verify the button background changes to success hover color
  6. Hover over the navigation tab Account (User avatar)
  7. Verify a green ring appears around the avatar and background color changes to indicate hover state
  8. Move mouse away from all elements and verify hover effects disappear
  • Verify that no errors appear in the JS console

Offline tests

Same as above.

QA Steps

Same as above.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
android_web.mp4
iOS: Native
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-08-25.at.21.29.31.mp4
MacOS: Chrome / Safari

For dark theme:

Screen.Recording.2025-08-25.at.9.16.27.PM.mov

For light theme:

Screen.Recording.2025-08-25.at.5.38.56.PM.mov
MacOS: Desktop
Screen.Recording.2025-08-25.at.9.22.18.PM.mov

- Add hover state styling to navigation tab bar items with background color change
- Add hover effect to floating action button with success hover background
- Add hover effect to navigation tab bar avatar with green ring indicator
- Add testID attributes for better testability
- Add comprehensive unit tests for hover functionality
- Add navigationTabBarItemHovered style to theme
@dannymcclain

Copy link
Copy Markdown
Contributor

If this is ready for a design review, let us know and myself or @dubielzyk-expensify can spin up a test build.

@cosmicvulpes cosmicvulpes marked this pull request as ready for review August 25, 2025 16:14
@cosmicvulpes cosmicvulpes requested review from a team as code owners August 25, 2025 16:14
@melvin-bot melvin-bot Bot requested review from getusha and removed request for a team August 25, 2025 16:14
@melvin-bot

melvin-bot Bot commented Aug 25, 2025

Copy link
Copy Markdown

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@dannymcclain

Copy link
Copy Markdown
Contributor

Videos are looking good to me. I don't think we really even need a test build here. Will wait for @dubielzyk-expensify to have a look before officially approving (Jon—go for it if it looks good to you!)

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

I'm gonna whip up a test build cause I think we might wanna tweak the hover icon color from success-hover to regular success given that's what the LHN do.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @dubielzyk-expensify has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@dubielzyk-expensify dubielzyk-expensify self-requested a review August 26, 2025 01:39
@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

It's looking pretty good. Let's change the hover icon color to be success instead of success-hover. It just looks a bit too muddy when we also apply the background color.

@cosmicvulpes

Copy link
Copy Markdown
Contributor Author

Updated @dubielzyk-expensify !

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

Can you gimme a little video so I can see?

@cosmicvulpes

Copy link
Copy Markdown
Contributor Author

Here it is:

Screen.Recording.2025-08-26.at.11.17.23.AM.mov

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

Ahh, sweet. Everything is good here from the design side. I'll approve that side and @getusha can handle the code bit 😄 Awesome job!

@dannymcclain

Copy link
Copy Markdown
Contributor

Love it! One last little nit pick if we can handle it here:

Ideally the outline around the green/red dot on all of these tabs should also change to the hover color when hovering so we don't get this bright line around it:
CleanShot 2025-08-26 at 09 27 26@2x

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

Oh, great 🦅👀 @dannymcclain . Yeah let's fix that before we merge

@cosmicvulpes

Copy link
Copy Markdown
Contributor Author

@getusha addressed code comments. PTAL

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hover effects makes sense, approving from a product perspective. Will leave the mobile conundrum to design, I agree with Danny doe!

@shawnborton

Copy link
Copy Markdown
Contributor

Yeah, definitely curious how the other tabs will look on mobile. I don't think we need to do anything here so maybe we just leave them as-is, but I like what you did with the global create button to mimic other Success buttons in the app.

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

Agree with what the designers are saying. I think there's also other effects we can apply if we want visual feedback on the tabs. But I'm always fan of adding a pressed state

@getusha

getusha commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

Other tabs would roughly look like this.

Screen.Recording.2025-09-05.at.12.20.25.in.the.afternoon.mov

@getusha

getusha commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

@cosmicvulpes Reassure test is failing.

@shawnborton

Copy link
Copy Markdown
Contributor

I don't think I love the full BG color on press for mobile, but curious what others think.

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

I don't mind it, but happy to go with other things if you have better suggestions @shawnborton . It's consistent with desktop and the finger will obscure most of it anyways. No strong feelings

@shawnborton

Copy link
Copy Markdown
Contributor

Fair point about desktop consistency... but on desktop, we use the fullBG for hover, and on mobile, we don't have hover... I think I would rather just do nothing on mobile for now?

@dannymcclain

Copy link
Copy Markdown
Contributor

I'm fine with doing nothing on mobile for now. The full background pressed state doesn't translate that well to mobile IMO.

@cosmicvulpes

Copy link
Copy Markdown
Contributor Author

@getusha that was a flaky test it seems. Everything is green now. 🟢

@cosmicvulpes

Copy link
Copy Markdown
Contributor Author

@getusha can we merge now?

@github-actions

github-actions Bot commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #69151.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/69151/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/69151/index.html
Android iOS
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/69151/NewExpensify.dmg https://69151.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

@shawnborton

Copy link
Copy Markdown
Contributor

Took it for a quick spin, feeling good to me 👍

@dubielzyk-expensify dubielzyk-expensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 2

@getusha getusha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melvin-bot melvin-bot Bot requested a review from MonilBhavsar September 9, 2025 12:52

@MonilBhavsar MonilBhavsar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@MonilBhavsar MonilBhavsar merged commit 0371820 into Expensify:main Sep 9, 2025
20 of 22 checks passed
@OSBotify

OSBotify commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.2.9-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.2.11-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 9.2.12-4 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants